Feat/surveys #170
Open
Feat/surveys #170
+885
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbrethorst
requested changes
Feb 8, 2025
src/components/stops/StopPane.svelte
Outdated
| @@ -114,6 +161,44 @@ | |||
| </div> | |||
| </div> | |||
| </div> | |||
| {#if showHeroQuestion && currentStopSurvey} | |||
| <div class="hero-question-container relative rounded-lg bg-gray-50 p-6 shadow"> | |||
There was a problem hiding this comment.
please extract the content inside of the {#if} into a new component.
src/lib/Surveys/surveyUtils.js
Outdated
| const now = new Date(); | ||
| return surveys.filter( | ||
| (survey) => | ||
| new Date(survey.end_date) > now && |
There was a problem hiding this comment.
it's valid for a survey to not have an end date, which makes it not appear on-screen as this filters it out as being invalid.
| @@ -0,0 +1,121 @@ | |||
| import { showSurveyModal, surveyStore } from '$stores/surveyStore.js'; | |||
|
|
|||
There was a problem hiding this comment.
Please write a couple basic unit tests for each of the functions in this file. That will help us ensure that there are no regressions going forward, and that we're all on the same page with regard to product behavior.
|
Hi @aaronbrethorst, You can continue reviewing now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #160